[libvirt] [PATCH 2/3] virsh: Fix virshDomainInterfaceSourceCompleter
Daniel P. Berrangé
berrange at redhat.com
Tue Jan 7 14:05:22 UTC 2020
On Tue, Jan 07, 2020 at 09:41:53AM +0100, Michal Privoznik wrote:
> Introduced in v5.10.0-449-gcf44ec5577 it used
> virshCommaStringListComplete() to generate list of options. But
> this is not correct because the '--source' argument of the
> 'domifaddr' doesn't accept a string list (for instance
> "arp,agent,lease") rather than a single string. Therefore, the
> completer must return these strings separately and thus must
> refrain from using virshCommaStringListComplete().
>
> At the same time, now that we have strings we need declared as
> an enum we can use TypeToString() instead of copying strings.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> tools/virsh-completer-domain.c | 17 ++++++++++-------
> tools/virsh-domain-monitor.c | 1 -
> tools/virsh-domain-monitor.h | 2 ++
> tools/virsh.h | 1 +
> 4 files changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list