[libvirt] [PATCH] po/Makefile.am: use SOURCE_DATE_EPOCH to set POT creation date

Daniel P. Berrangé berrange at redhat.com
Tue Jan 7 14:40:24 UTC 2020


On Tue, Jan 07, 2020 at 03:37:44PM +0100, Pavel Hrdina wrote:
> When building RPMs for libvirt the PO files are part of libvirt-libs
> package.  Now that we generate libvirt.pot during build time the POT
> creation date is also generated at that time.
> 
> The issue here is that when building libvirt-libs for x86_64 and i686
> the generated libvirt.pot file will have different POT creation date
> which affects installed PO files as well which leads to conflict when
> installing both x86_64 and i686 packages.

Bad for distros doing reproducable builds too

> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  po/Makefile.am | 9 +++++++++
>  1 file changed, 9 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list