[libvirt] [PATCH v3 00/11] esx: various improvements

[Michal Privoznik]

On 12/20/19 3:58 PM, Pino Toscano wrote:
> - fix a bug in the esx VI generator
> - implement connectListAllStoragePools, so
>    virConnectListAllStoragePools() works
> - implement connectListAllNetworks, so virConnectListAllNetworks()
>    works
> - implement storagePoolListAllVolumes, so virStoragePoolListAllVolumes()
>    works
> - implement domainGetHostname, so virDomainGetHostname() works
> - implement domainInterfaceAddresses only for
>    VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT, so
>    virDomainInterfaceAddresses() partially works
> - improve virErrorNumber for some virReportError() calls
> 
> TODO:
> - handle the comments in v2 about esxStoragePoolListAllVolumes()
> 
> Changes from v2:
> - pushed patches reviewed with no changes required
> - integrated the Reviewed-By in patches that required very minor
>    changes, will push them on request
> - fixed bool/size_t error/count handling
> - bumped API version numbers to 6.0.0
> - fixed a bug in the esx VI generator
> - implemented domainGetHostname
> - implemented domainInterfaceAddresses
> 
> 
> Pino Toscano (11):
>    esx: implement connectListAllStoragePools
>    esx: implement connectListAllNetworks
>    esx: split datastorePathToStorageVol helper
>    esx: split scsilunToStorageVol helper
>    esx: implement storagePoolListAllVolumes
>    esx: improve some of the virErrorNumber used
>    esx: implement domainGetHostname
>    esx: generator: fix free of elements in lists
>    esx: generator: add GuestNicInfo object
>    esx: implement domainInterfaceAddresses
>    docs: document implemented APIs in esx
> 
>   docs/drvesx.html.in                 |   7 +
>   docs/news.xml                       |  14 ++
>   scripts/esx_vi_generator.py         |  27 +++-
>   src/esx/esx_driver.c                | 220 ++++++++++++++++++++++++++++
>   src/esx/esx_network_driver.c        |  68 ++++++++-
>   src/esx/esx_storage_backend_iscsi.c | 202 +++++++++++++++++++++----
>   src/esx/esx_storage_backend_vmfs.c  | 220 ++++++++++++++++++++++++++--
>   src/esx/esx_storage_driver.c        |  84 +++++++++++
>   src/esx/esx_util.c                  |   4 +-
>   src/esx/esx_vi.c                    |  36 ++---
>   src/esx/esx_vi_generator.input      |  54 +++++++
>   11 files changed, 862 insertions(+), 74 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal