[libvirt] [jenkins-ci PATCH v2 2/2] mappings: Adjust mappings for OpenSUSE 15.1

Andrea Bolognani abologna at redhat.com
Wed Jan 8 17:43:01 UTC 2020

On Wed, 2020-01-08 at 15:46 +0100, Fabiano Fidêncio wrote:
> For all the projects which rely on meson, the version present on
> OpenSUSE 15.1 is too old (0.46.0) to build our projects, which requires
> 0.49.0. Knowing that, pip is going to be used there.

I would make this change in a separate commit, since you're not
really adding any new package but rather change the source it's
coming from.

Speaking of which, this commit should go *before* the one where you
add the respective projects to libvirt-opensuse-151.

> The adjustments done, per project, are:
> - gtk-vnc:
>   - gdk-pixbuf: gdk-pixbuf-devel
>   - pulseaudio: libpulse-devel
> - libvirt-dbus:
>   - dbus: dbus-1
>   - python3-dbus: python3-dbus-python
>   - python3-pip: python3-pip
> - libvirt-go:
>   - golang: go
> - libvirt-perl:
>   - perl-Time-HiRes:
>     - Although there's not an equivalent package for perl-Time-HiRes,
>       OpenSUSE seems to have it as part of its base perl packages.
>   - perl-generators:
>     - It's a Fedora/RHEL-ism used for RPM auto-dependencies, not present
>       nor needed on OpenSUSE;

This last point is useful, because it explains why a non-obvious
choice was made; the rest of the commit message, not so much IMHO,
because all other choices neatly fall in line with what is already
present so you're basically just duplicating the contents of the

Please leave this part in the commit message and drop the rest.

> +++ b/guests/vars/mappings.yml
>    gtk-update-icon-cache:
>      default: gtk-update-icon-cache
> +    OpenSUSE:

This should be

  OpenSUSE: gtk3-tools

because that's the package that contains the gtk-update-icon-cache

>    perl-Time-HiRes:
>      deb: libtime-hr-perl
>      pkg: p5-Time-HiRes
>      rpm: perl-Time-HiRes
> +    OpenSUSE:

This should be

  OpenSUSE: perl

becasue that's the package that includes the module; see the mapping
for perl-Archive-Tar for prior art.

>    perl-generators:
>      rpm: perl-generators
>      CentOS7:
> +    OpenSUSE:

OpenSUSE goes before CentOS7, as the latter is more generic.

>    python3-pip:
> +    OpenSUSE: python3-pip

This should be

  OpenSUSE151: python3-pip

because hopefully the next version of openSUSE will contain a recent
enough version of Meson :)

Andrea Bolognani / Red Hat / Virtualization

More information about the libvir-list mailing list