[libvirt] [PATCH 1/3] conf: backup: Allow configuration of names exported via NBD

[Eric Blake]

On 1/9/20 12:31 PM, Peter Krempa wrote:
> If users wish to use different name for exported disks or bitmaps
> the new fields allow to do so. Additionally they also document the
> current settings.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   docs/formatbackup.html.in                             |  9 +++++++++
>   docs/schemas/domainbackup.rng                         |  8 ++++++++
>   src/conf/backup_conf.c                                | 11 +++++++++++
>   src/conf/backup_conf.h                                |  2 ++
>   tests/domainbackupxml2xmlin/backup-pull-seclabel.xml  |  2 +-
>   tests/domainbackupxml2xmlout/backup-pull-seclabel.xml |  2 +-
>   6 files changed, 32 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatbackup.html.in b/docs/formatbackup.html.in
> index 1c690901c7..7d2c6f1599 100644
> --- a/docs/formatbackup.html.in
> +++ b/docs/formatbackup.html.in
> @@ -85,6 +85,15 @@
>                 <dd>Setting this attribute to <code>yes</code>(default) specifies
>                   that the disk should take part in the backup and using
>                   <code>no</code> excludes the disk from the backup.</dd>
> +              <dt><code>exportname</code></dt>
> +              <dd>Allows to modify the NBD export name for the given disk.

Allows modification of the NBD export name

> +                By default equal to disk target.
> +                Valid only for pull mode backups. </dd>

Is the space after '.' needed?

> +              <dt><code>exportbitmap</code></dt>
> +              <dd>Allows to modify the name of the bitmap describing dirty

Allows modification of the name

> +                blocks for an incremental backup exported via NBD export name
> +                for the given disk.
> +                Valid only for pull mode backups. </dd>

Another trailing space

Otherwise looks fine, once you also fix Daniel's nit.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org