[libvirt] [PATCH] qemu: Refuse to use "ps2" on machines that do not have this bus

Daniel Henrique Barboza danielhb413 at gmail.com
Wed Jan 15 14:44:23 UTC 2020

On 1/15/20 9:23 AM, Thomas Huth wrote:
> The "ps2" bus is only available on certain machines like x86. On
> machines like s390x, we should refuse to add a device to this bus
> instead of silently ignoring it.
> Looking at the QEMU sources, PS/2 is only available if the QEMU binary
> has the "i8042" device, so let's check for that and only allow "ps2"
> devices if this QEMU device is available, or if we're on x86 anyway
> (so we don't have to fake the QEMU_CAPS_DEVICE_I8042 capability in
> all the tests that use <input ... bus='ps2'/> in their xml data).
> Reported-by: Sebastian Mitterle <smitterl at redhat.com>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1763191
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

More information about the libvir-list mailing list