[PATCH 2/2] run.in: Include tools directory on $PATH.

Richard W.M. Jones rjones at redhat.com
Thu Jan 16 17:15:42 UTC 2020


You normally want to run the locally compiled copy of virsh.  Trying
to run the installed version with the locally compiled library is a
recipe for problems with missing symbols and so on.  By adding tools
to the path we can ensure that (eg) the libguestfs test suite will use
compatible copies of the library and virsh.

Signed-off-by: Richard W.M. Jones <rjones at redhat.com>
---
 run.in | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/run.in b/run.in
index 3118f9a9a4..d508e64802 100644
--- a/run.in
+++ b/run.in
@@ -21,12 +21,10 @@
 # With this script you can run libvirt programs without needing to
 # install them first.  You just have to do for example:
 #
-#   ./run ./tools/virsh [args ...]
+#   ./run virsh [args ...]
 #
-# If you are already in the tools/ subdirectory, then the following
-# command will also work:
-#
-#   ../run ./virsh [...]
+# Note that this runs the locally compiled copy of virsh which
+# is usually want you want.
 #
 # You can also run the C programs under valgrind like this:
 #
@@ -38,7 +36,7 @@
 #
 # This also works with sudo (eg. if you need root access for libvirt):
 #
-#   sudo ./run ./tools/virsh list --all
+#   sudo ./run virsh list --all
 #
 #----------------------------------------------------------------------
 
@@ -58,6 +56,9 @@ export LD_LIBRARY_PATH
 prepend PKG_CONFIG_PATH "$b/src"
 export PKG_CONFIG_PATH
 
+prepend PATH "$b/tools"
+export PATH
+
 # Ensure that any 3rd party apps using libvirt.so from the build tree get
 # files resolved to the build/source tree too. Typically useful for language
 # bindings running tests against non-installed libvirt.
-- 
2.24.1




More information about the libvir-list mailing list