[libvirt PATCH] bhyve: fix typos checking CPU dies

Daniel P. Berrangé berrange at redhat.com
Fri Jan 17 13:02:30 UTC 2020


This fixes a build bug introduced by

  commit fbf27730a36da573b1065c179f4d96b9a751f22f
  Author: Daniel P. Berrangé <berrange at redhat.com>
  Date:   Mon Dec 16 11:16:51 2019 +0000

    conf: add support for specifying CPU "dies" parameter

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---

Pushed as a build fix for FreeBSD

 src/bhyve/bhyve_command.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index d78221aea8..a8bfc0aa72 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -453,10 +453,10 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn,
     /* CPUs */
     virCommandAddArg(cmd, "-c");
     if (def->cpu && def->cpu->sockets) {
-        if (def->dies != 1) {
+        if (def->cpu->dies != 1) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                            _("Only 1 die per socket is supported"));
-            goto cleanup;
+            goto error;
         }
         if (nvcpus != def->cpu->sockets * def->cpu->cores * def->cpu->threads) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-- 
2.23.0




More information about the libvir-list mailing list