[PATCH 3/4] qemu: Fix value of 'device' argument for blockdev-mirror

Eric Blake eblake at redhat.com
Thu Jan 23 16:38:04 UTC 2020


On 1/23/20 9:57 AM, Peter Krempa wrote:
> When using blockdev configurations the 'device' argument of
> 'blockdev-mirror' must correspond to the topmost node in the block node
> graph. Libvirt didn't do this properly in case when 'copy_on_read'
> option was enabled on the disk.
> 
> Use qemuDomainDiskGetTopNodename to fix it for the blockdev-mirror calls
> in qemuDomainBlockCopy and the non-shared-storage migration.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_driver.c    | 2 +-
>   src/qemu/qemu_migration.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list