[libvirt PATCHv2 06/10] qemu: add virtiofs_debug to qemu.conf

[Peter Krempa]

On Thu, Jan 23, 2020 at 18:46:07 +0100, Ján Tomko wrote:
> Add a 'virtiofs_debug' option for tuning whether to run virtiofsd
> in debug mode.

IMO the option should be "virtiofsd_debug" so that it's really clear
that it's meant for the daemon. In case of gluster which you put it
close to the option is actually for the client.

> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  src/qemu/libvirtd_qemu.aug         | 1 +
>  src/qemu/qemu.conf                 | 7 +++++++
>  src/qemu/qemu_conf.c               | 2 ++
>  src/qemu/qemu_conf.h               | 1 +
>  src/qemu/test_libvirtd_qemu.aug.in | 1 +
>  5 files changed, 12 insertions(+)
> 
> diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
> index 557b6f38f8..32d79f20db 100644
> --- a/src/qemu/libvirtd_qemu.aug
> +++ b/src/qemu/libvirtd_qemu.aug
> @@ -116,6 +116,7 @@ module Libvirtd_qemu =
>     let nvram_entry = str_array_entry "nvram"
>  
>     let debug_level_entry = int_entry "gluster_debug_level"
> +                 | bool_entry "virtiofs_debug"
>  
>     let memory_entry = str_entry "memory_backing_dir"
>  
> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> index b6805ffc41..84f01a126d 100644
> --- a/src/qemu/qemu.conf
> +++ b/src/qemu/qemu.conf
> @@ -809,6 +809,13 @@
>  #
>  #gluster_debug_level = 9
>  
> +# virtiofs debug
> +#
> +# Whether to pass the debug option to virtiofsd command line.

I'd make it more obvious that this actually enables debugging of the
daemon.


> +# Possible values are 0 or 1.
> +#
> +#virtiofs_debug = 1
> +
>  # To enhance security, QEMU driver is capable of creating private namespaces
>  # for each domain started. Well, so far only "mount" namespace is supported. If
>  # enabled it means qemu process is unable to see all the devices on the system,