[libvirt] [PATCH v4 6/6] qemu: introduce a new "virt-qemu-run" program

Andrea Bolognani abologna at redhat.com
Mon Jan 27 16:32:34 UTC 2020


On Fri, 2020-01-10 at 10:34 +0000, Daniel P. Berrangé wrote:
> +++ b/src/qemu/Makefile.inc.am
> @@ -243,3 +243,16 @@ EXTRA_DIST += \
>  	qemu/THREADS.txt \
>  	libvirt_qemu_probes.d \
>  	$(NULL)
> +
> +QEMU_SHIM_SOURCES = qemu/qemu_shim.c
> +
> +EXTRA_DIST += $(QEMU_SHIM_SOURCES)
> +
> +if WITH_QEMU
> +bin_PROGRAMS += virt-qemu-run

Arriving quite late to the party, but is it a good idea to install
virt-qemu-run under /usr/bin at this point in time?

It's built on the embedded driver feature, which is clearly marked
as experimental in the documentation, and I'm concerned making it
available under $PATH will give the impression that it's a fully
supported solution, especially since neither the program itself nor
its man page contain language telling the user otherwise.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list