[libvirt PATCH 06/10] conf: remove outdated comments

Ján Tomko jtomko at redhat.com
Tue Jan 28 10:31:22 UTC 2020


Some *ParseXML functions have comments stating what kind of device
they parse with an outdated list of parameters, with the exception
of virDomainFSDefParseXML which claims to parse a disk.

Remove them, assuming the function names are descriptive enough.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/conf/domain_conf.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 853cfddf1b..70501c4ffc 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7598,9 +7598,6 @@ virDomainDeviceAliasIsUserAlias(const char *aliasStr)
 }
 
 
-/* Parse the XML definition for a device address
- * @param node XML nodeset to parse for device address definition
- */
 static int
 virDomainDeviceInfoParseXML(virDomainXMLOptionPtr xmlopt G_GNUC_UNUSED,
                             xmlNodePtr node,
@@ -10040,9 +10037,6 @@ virDomainDiskDefParsePrivateData(xmlXPathContextPtr ctxt,
 #define VENDOR_LEN  8
 #define PRODUCT_LEN 16
 
-/* Parse the XML definition for a disk
- * @param node XML nodeset to parse for disk definition
- */
 static virDomainDiskDefPtr
 virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt,
                          xmlNodePtr node,
@@ -10721,9 +10715,6 @@ virDomainControllerModelTypeToString(virDomainControllerDefPtr def,
 }
 
 
-/* Parse the XML definition for a controller
- * @param node XML nodeset to parse for controller definition
- */
 static virDomainControllerDefPtr
 virDomainControllerDefParseXML(virDomainXMLOptionPtr xmlopt,
                                xmlNodePtr node,
@@ -11094,9 +11085,6 @@ virDomainNetGenerateMAC(virDomainXMLOptionPtr xmlopt,
 }
 
 
-/* Parse the XML definition for a disk
- * @param node XML nodeset to parse for disk definition
- */
 static virDomainFSDefPtr
 virDomainFSDefParseXML(virDomainXMLOptionPtr xmlopt,
                        xmlNodePtr node,
@@ -11521,10 +11509,6 @@ virDomainChrSourceReconnectDefParseXML(virDomainChrSourceReconnectDefPtr def,
 }
 
 
-/* Parse the XML definition for a network interface
- * @param node XML nodeset to parse for net definition
- * @return 0 on success, -1 on failure
- */
 static virDomainNetDefPtr
 virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt,
                         xmlNodePtr node,
@@ -12909,7 +12893,6 @@ virDomainChrDefNew(virDomainXMLOptionPtr xmlopt)
 }
 
 /* Parse the XML definition for a character device
- * @param node XML nodeset to parse for net definition
  *
  * The XML we're dealing with looks like
  *
-- 
2.21.0




More information about the libvir-list mailing list