[libvirt] [PATCH 2/7] conf: expand iotune params if only group name is given

Daniel P. Berrangé berrange at redhat.com
Tue Jan 28 14:18:09 UTC 2020

On Wed, Jan 08, 2020 at 09:49:26AM +0300, Nikolay Shirokovskiy wrote:
> Currenly if only iotune group name is given for some disk and
> no any params then later start of domain will fail. I guess it will
> be convinient to allow such configuration if there is another


> disk in the same iotune group with iotune params set. The meaning
> is that the first disk have same iotunes and the latter. Thus
> one can easyly add disk to iotune group - just add group name

"easily"   and   s/add disk/add a disk/

> parameter and no need to copy all the params.
> Also let's expand iotunes params in the described case so we don't
> need to refer to another disk to know iotunes and this will make
> logic in many places simple.
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>  src/conf/domain_conf.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list