[RFC PATCH 12/16] tests: qemublock: Add synthetic snapshot+checkpoint test data

Eric Blake eblake at redhat.com
Tue Jan 28 14:37:00 UTC 2020


On 1/9/20 12:21 PM, Peter Krempa wrote:
> Add a faked qemu output which would simulate scenario where libvirt
> would take a snapshot and checkpoint simultaneously. This is visible in
> libvirt-2-format node where bitmap 'c' appears, but bitmap 'b' which is
> active in the previous layer is not present.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   tests/qemublocktest.c                         |   1 +
>   .../snapshots-synthetic-checkpoint.json       | 827 ++++++++++++++++++

Hmm - proof why we want qemu to add the optional flat parameter to avoid 
the O(n^2) growth of output as backing chains get longer.

>   .../bitmap/snapshots-synthetic-checkpoint.out |  13 +
>   3 files changed, 841 insertions(+)
>   create mode 100644 tests/qemublocktestdata/bitmap/snapshots-synthetic-checkpoint.json
>   create mode 100644 tests/qemublocktestdata/bitmap/snapshots-synthetic-checkpoint.out
> 

The test itself looks sane.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list