[PATCH 1/4] lxc: refactor lxcNetworkParseData pointers to use new structures

Daniel P. Berrangé berrange at redhat.com
Tue Jan 28 14:40:47 UTC 2020

On Mon, Jan 27, 2020 at 11:25:45AM -0300, Julio Faracco wrote:
> Struct lxcNetworkParseData is being used as a single pointer which
> iterates through LXC config lines. It means that it will be applied as a
> network each time that a new type appears. After, the same struct is
> used to populate a new network interface. This commit changes this logic
> to multiple lxcNetworkParseData to move this strcuture to an array. It
> makes more sense if we are using indexes to fill interface settings.
> This is better to improve code clarity.
> This commit still introduces *Legacy() functions to keep support of
> network old style definitions.
> Signed-off-by: Julio Faracco <jcfaracco at gmail.com>
> ---
>  src/lxc/lxc_native.c | 129 +++++++++++++++++++++++--------------------
>  1 file changed, 68 insertions(+), 61 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list