[PATCH v2 1/9] virsh: Work around virSecretFree quirks

Daniel P. Berrangé berrange at redhat.com
Tue Jan 28 14:51:22 UTC 2020


On Fri, Jan 24, 2020 at 05:08:33PM +0100, Peter Krempa wrote:
> Similarly to other libvirt object freeing APIs the function resets the
> libvirt error when called and doesn't take NULL gracefully. Install the
> workaround and g_autoptr handlers similarly to the 'virshDomain' type.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  build-aux/syntax-check.mk      |  2 +-
>  tools/virsh-completer-secret.c |  3 ++-
>  tools/virsh-secret.c           | 22 ++++++++++------------
>  tools/virsh-util.c             | 11 +++++++++++
>  tools/virsh-util.h             |  5 +++++
>  5 files changed, 29 insertions(+), 14 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list