[libvirt PATCH v2 26/56] src: conditionalize use of O_DIRECT

Pavel Hrdina phrdina at redhat.com
Tue Jan 28 16:55:27 UTC 2020

On Tue, Jan 28, 2020 at 01:11:07PM +0000, Daniel P. Berrangé wrote:
> The O_DIRECT flag is not available on all platforms, so we
> must introduce a compat define the same way gnulib does.
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/util/iohelper.c | 4 ++++
>  src/util/virfile.c  | 4 ++++
>  2 files changed, 8 insertions(+)

I would rather have all the O_* compat defines at one place then
scattered through our code.

We have the O_CLOEXEC in src/internal.h, O_DIRECT in these two files
and following patch adds guard around O_BINARY in

I'll leave it up to you if decide to group all of them or leave it as
it is.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200128/5979b0fa/attachment-0001.sig>

More information about the libvir-list mailing list