[PATCH v2 7/7] apparmor: Drop 'Last modified' comment from profiles

[Christian Ehrhardt]

On Thu, Jan 30, 2020 at 8:05 AM Michal Privoznik <mprivozn at redhat.com>
wrote:

> At the beginning of each profile we have a comment that says when
> the profile was last updated. In theory, it makes sense because
> one can see immediately if they are using an outdated profile.
> However, we don't do a good job in keeping the comments in sync
> with reality and also sysadmins should rather use their package
> manager to find out libvirt version which installed the profiles.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>

Acked-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>


> ---
>  src/security/apparmor/libvirt-lxc                | 2 --
>  src/security/apparmor/libvirt-qemu               | 2 --
>  src/security/apparmor/usr.libexec.virt-aa-helper | 1 -
>  src/security/apparmor/usr.sbin.libvirtd          | 1 -
>  4 files changed, 6 deletions(-)
>
> diff --git a/src/security/apparmor/libvirt-lxc
> b/src/security/apparmor/libvirt-lxc
> index 4bfb503aa5..e556f2a7bd 100644
> --- a/src/security/apparmor/libvirt-lxc
> +++ b/src/security/apparmor/libvirt-lxc
> @@ -1,5 +1,3 @@
> -# Last Modified: Fri Feb  7 13:01:36 2014
> -
>    #include <abstractions/base>
>
>    umount,
> diff --git a/src/security/apparmor/libvirt-qemu
> b/src/security/apparmor/libvirt-qemu
> index 6942b83969..80986aec61 100644
> --- a/src/security/apparmor/libvirt-qemu
> +++ b/src/security/apparmor/libvirt-qemu
> @@ -1,5 +1,3 @@
> -# Last Modified: Wed Sep 3 21:52:03 2014
> -
>    #include <abstractions/base>
>    #include <abstractions/consoles>
>    #include <abstractions/nameservice>
> diff --git a/src/security/apparmor/usr.libexec.virt-aa-helper
> b/src/security/apparmor/usr.libexec.virt-aa-helper
> index 72a2fecebe..e037ee7e26 100644
> --- a/src/security/apparmor/usr.libexec.virt-aa-helper
> +++ b/src/security/apparmor/usr.libexec.virt-aa-helper
> @@ -1,4 +1,3 @@
> -# Last Modified: Mon Apr  5 15:10:27 2010
>  #include <tunables/global>
>
>  profile virt-aa-helper /usr/{lib,lib64,libexec}/libvirt/virt-aa-helper {
> diff --git a/src/security/apparmor/usr.sbin.libvirtd
> b/src/security/apparmor/usr.sbin.libvirtd
> index 27314b1512..a7bdf4d2fe 100644
> --- a/src/security/apparmor/usr.sbin.libvirtd
> +++ b/src/security/apparmor/usr.sbin.libvirtd
> @@ -1,4 +1,3 @@
> -# Last Modified: Mon Apr  5 15:03:58 2010
>  #include <tunables/global>
>  @{LIBVIRT}="libvirt"
>
> --
> 2.24.1
>
>

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200130/6192eef4/attachment-0001.htm>