[libvirt PATCH v2 37/56] tests: refactor event test to not run lock step
phrdina at redhat.com
Fri Jan 31 09:08:18 UTC 2020
On Tue, Jan 28, 2020 at 01:11:18PM +0000, Daniel P. Berrangé wrote:
> The current event loop test suite has two threads running
> in lockstep. This was just about viable when we have full
> control over the internal details of the event loop impl.
> When we're using the GLib event loop though there are
> things going on that we don't know about, such as use of
> eventfd() file descriptors. This will break the assumptions
> in the test suite, causing non-deterministic failures.
> This change switches the event loop thread to run fully
> asynchronously from the test suite cases. This is slightly
> weaker validation, but the only way we can get a reliable
> test suite.
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> tests/eventtest.c | 151 +++++++++++++++++++---------------------------
> 1 file changed, 63 insertions(+), 88 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the libvir-list