[libvirt PATCH v2 43/56] util: conditionalize FD stream to exclude WIN32

Pavel Hrdina phrdina at redhat.com
Fri Jan 31 15:13:45 UTC 2020

On Tue, Jan 28, 2020 at 01:11:24PM +0000, Daniel P. Berrangé wrote:
> Almost none of the virFDStream code will actually work
> on WIN32 builds, nor is it used except for in the
> virtualbox driver for screenshots. It is simpler to
> wrap it all in a '#ifndef WIN32'.
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/util/virfdstream.c | 122 +++++++++++++++++++++++++++++++----------
>  1 file changed, 93 insertions(+), 29 deletions(-)

If we are OK with breaking screenshots on virtualbox.  I guess that if
someone is really using it we will have a bug report and we can solve it.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200131/68bf6e3c/attachment-0001.sig>

More information about the libvir-list mailing list