[libvirt PATCH v2 48/56] src: convert code to use virPipe APIs

Pavel Hrdina phrdina at redhat.com
Fri Jan 31 16:04:38 UTC 2020


On Tue, Jan 28, 2020 at 01:11:29PM +0000, Daniel P. Berrangé wrote:
> This addreses portability to Windows and standardizes
> error reporting. This fixes a number of places which
> failed to set O_CLOEXEC or failed to report errors.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/libxl/libxl_migration.c |  6 ++----
>  src/locking/lock_daemon.c   |  2 +-
>  src/logging/log_daemon.c    |  2 +-
>  src/logging/log_handler.c   |  6 ++----
>  src/lxc/lxc_process.c       |  5 +----
>  src/qemu/qemu_migration.c   | 25 +++++++++----------------
>  src/qemu/qemu_tpm.c         |  5 +----
>  src/remote/remote_daemon.c  |  2 +-
>  src/rpc/virnetdaemon.c      |  5 +----
>  src/rpc/virnetsocket.c      |  5 +----
>  src/util/vircommand.c       | 18 +++++-------------
>  src/util/virfdstream.c      |  5 +----
>  src/util/virfile.c          |  5 +----
>  src/util/virpolkit.c        |  2 +-
>  src/util/virprocess.c       |  5 +----
>  tests/commandtest.c         |  4 ++--
>  tests/eventtest.c           |  2 +-
>  tests/testutils.c           |  2 +-
>  tools/virsh-domain.c        |  8 ++++----
>  tools/vsh.c                 |  8 +++-----
>  20 files changed, 40 insertions(+), 82 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200131/36e847e0/attachment-0001.sig>


More information about the libvir-list mailing list