[PATCH 2/9] virstring: Introduce virStringIsNull()

Michal Privoznik mprivozn at redhat.com
Fri Jul 3 13:13:29 UTC 2020


On 7/3/20 2:08 PM, Ján Tomko wrote:
> On a Friday in 2020, Michal Privoznik wrote:
>> This function will be used to detect zero buffers (which are
>> going to be interpreted as hole in virStream later).
>>
>> I shamelessly took inspiration from coreutils.
>>
> 
> How is that okay, isn't coreutils GPL-licensed?

Well, I only took inspiration in that code, I haven't copied it.
But this idea of using memcmp() is quite old and described for instance 
in this blog post too:

https://rusty.ozlabs.org/?p=560

Do you want to switch to something else instead? If so, how can we make 
sure it's not already somewhere in a code with incompatible license?

Michal




More information about the libvir-list mailing list