[libvirt PATCH 27/31] src: unify virFileActivateDirOverride()

Daniel P. Berrangé berrange at redhat.com
Thu Jul 9 15:21:32 UTC 2020

On Thu, Jul 02, 2020 at 02:25:25PM +0200, Pavel Hrdina wrote:
> We have two functions to set that we want to override directory where to
> look for libvirt files, one checks the binary name and the other one
> checks env variable.
> This patch removes the binary name check to simplify code by using only
> the env variable.
> This change will be required for Meson introduction where the binary
> name doesn't have any prefix by default.

This means that we won't be able to run  "./src/libvirtd" directly from
the build dir - we'll *always* have to use  "./run ./src/libvirtd" to
get the env var set IIUC.

Instead of checking the binary name, can we check for existance of a
known valid build file in the directory we're running the binary from.
eg look for "Makefile" or "ninja.build" or something like that.

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list