[libvirt PATCH 249/351] meson: src: add check-admin-symfile test

Pavel Hrdina phrdina at redhat.com
Thu Jul 16 09:58:05 UTC 2020


Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/admin/Makefile.inc.am | 10 +---------
 src/meson.build           |  7 +++++++
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am
index ec084299b85..a2af10a158d 100644
--- a/src/admin/Makefile.inc.am
+++ b/src/admin/Makefile.inc.am
@@ -2,14 +2,6 @@
 
 ADMIN_SYM_FILES = $(srcdir)/admin/libvirt_admin_private.syms
 
-if WITH_LINUX
-check-admin-symfile: admin/libvirt_admin.syms libvirt-admin.la
-	$(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-symfile.py \
-		admin/libvirt_admin.syms .libs/libvirt-admin.so
-else ! WITH_LINUX
-check-admin-symfile:
-endif ! WITH_LINUX
-
 check-admin-symsorting:
 	$(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-symsorting.py \
 		$(srcdir) $(ADMIN_SYM_FILES)
@@ -18,4 +10,4 @@ check-admin-drivername:
 	$(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-drivername.py \
 		$(srcdir)/admin/libvirt_admin_public.syms
 
-check-admin: check-admin-symfile check-admin-symsorting check-admin-drivername
+check-admin: check-admin-symsorting check-admin-drivername
diff --git a/src/meson.build b/src/meson.build
index 3f1c456245a..9a2a152f316 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -846,6 +846,13 @@ if host_machine.system() == 'linux'
     args: [ check_symfile_prog.path(), libvirt_syms, libvirt_lib ],
     env: runutf8,
   )
+
+  test(
+    'check-admin-symfile',
+    python3_prog,
+    args: [ check_symfile_prog.path(), libvirt_admin_syms, libvirt_admin_lib ],
+    env: runutf8,
+  )
 endif
 
 test(
-- 
2.26.2




More information about the libvir-list mailing list