[libvirt PATCH 000/351] port libvirt to Meson build system
phrdina at redhat.com
Fri Jul 17 17:26:08 UTC 2020
On Fri, Jul 17, 2020 at 03:28:52PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > So I was finally able to produce the patches to port libvirt to Meson.
> > Obviously, it is a lot of changes. It might look that some of the
> > patches could be squashed together but I would rather have it as
> > separated as possible to make the review not that difficult.
> > Once we are done with review I suggest to squash all patches to single
> > patch as it doesn't make sense to keep them separated as it will not be
> > possible to build complete libvirt code by any of the build systems.
> > Trying to achieve that would be even more challenging and the review
> > would me more difficult.
> > The reasoning behind taking this approach is to have 1:1 conversion from
> > autotools to Meson where each patch removes that part from autotools. It
> > serves as a check that nothing is skipped and to make sure that the
> > conversion is complete.
> > As probably most of us know Meson is completely different build system
> > and one of the most challenging things was to deal with the fact that
> > meson doesn't allow user functions and that everything has to be defined
> > before it is used.
> > Patches are available in my Gitlab repo as well:
> > git clone -b meson https://gitlab.com/phrdina/libvirt.git
> > and link to Giltab pipeline:
> > https://gitlab.com/phrdina/libvirt/-/pipelines/167276632
> FWIW, some unit tests fail for me - Fedora 31, with pip installed meson 0.55
> 11/154 check-virnetprotocol FAIL 0.09s (exit status 1)
Right, they changed the name of internal temporary directories where
the object files are stored. They are required for pdwtags so I need to
figure out a better way how to get the object file path.
I knew that it was not that robust, sigh.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the libvir-list