[PATCH v2 04/13] rpc: don't unref service ref on socket behalf twice

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Thu Jul 23 10:14:04 UTC 2020


Second unref was added in [1]. We don't need it actually as
we pass free callback to virNetSocketAddIOCallback thus
when we call virNetSocketRemoveIOCallback the extra ref for
callback will be dropped without extra efforts.

[1] 355d8f470f9: virNetServerServiceClose: Don't leak sockets

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
---
 src/rpc/virnetserverservice.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/rpc/virnetserverservice.c b/src/rpc/virnetserverservice.c
index 9d5df45..e4165ea 100644
--- a/src/rpc/virnetserverservice.c
+++ b/src/rpc/virnetserverservice.c
@@ -449,6 +449,5 @@ void virNetServerServiceClose(virNetServerServicePtr svc)
     for (i = 0; i < svc->nsocks; i++) {
         virNetSocketRemoveIOCallback(svc->socks[i]);
         virNetSocketClose(svc->socks[i]);
-        virObjectUnref(svc);
     }
 }
-- 
1.8.3.1




More information about the libvir-list mailing list