[libvirt PATCH 217/351] meson: src: build libvirt_leaseshelper binary

Pavel Hrdina phrdina at redhat.com
Fri Jul 24 15:35:08 UTC 2020

On Fri, Jul 24, 2020 at 09:16:40AM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:57:33 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> >  src/network/Makefile.inc.am | 22 ----------------------
> >  src/network/meson.build     | 12 ++++++++++++
> >  2 files changed, 12 insertions(+), 22 deletions(-)
> I took this one as a representative sample to compare how it's linked.
> The only difference I found is that 'libnl-route-3' is not linked with
> meson any more. That certainly doesn't matter in this case, but it's
> maybe worth checking whether it's linked in the appropriate place.

So I did some digging and the libnl-route-3 library was added by commit
<60fb8a22ee63481b6574a04304f740f50a133754> which introduced support for
libnl-3. However, it looks like we don't use any symbols from
libnl-route-3 library.

Meson uses -Wl,--as-needed which tells linker to use libraries that
satisfies undefined symbols which confirms that we don't use any symbols
from libnl-route-3.

I'll add it to my todo list to drop the libnl-route-3 check once we
finish this series as it can wait.

Nice catch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200724/3e1f86be/attachment-0001.sig>

More information about the libvir-list mailing list