[PATCH libvirt-python 0/5] Fixes from adding type annotation

Philipp Hahn hahn at univention.de
Sat Jul 25 21:45:32 UTC 2020


Hello,

Am 27.04.20 um 15:44 schrieb Philipp Hahn:
> as announced a long time ago with
> <https://www.redhat.com/archives/libvir-list/2018-November/msg00291.html>
> and recently refreshed with
> <https://www.redhat.com/archives/libvir-list/2020-April/msg00892.html>
> I'm working on adding PEP 484 type hints
> <https://www.python.org/dev/peps/pep-0484/> to the Python binding of
> libvirt.
> 
> I have finished this work now and have a working version at
> <https://github.com/univention/libvirt-python/tree/typing> which
> consists of 90 patches in total as I has to go over evry file to
> understand and fix all things.

I just opened a merge request
<https://gitlab.com/libvirt/libvirt-python/-/merge_requests/9> for my
code at <https://gitlab.com/pmhahn/libvirt-python/-/tree/typing>.

This also unearthed severl bugs where C-pointer point to the wrong
types, which lead to strange crashes. The fixes for them are at the
start of my current branch, except
<https://gitlab.com/pmhahn/libvirt-python/-/commit/9fdf8e9ece4b6695bcddaeb2f998bc11f57e2735>
which is more tricky.

If you want to fast-pache them I can try to extract those patches into a
separate branch, which can be merged without my other work.

Philipp




More information about the libvir-list mailing list