[libvirt PATCH 246/351] meson: src: add check-augeas test

Peter Krempa pkrempa at redhat.com
Tue Jul 28 07:51:40 UTC 2020


On Thu, Jul 16, 2020 at 11:58:02 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  scripts/check-augeas.sh | 12 ++++++++++++
>  scripts/meson.build     |  1 +
>  src/Makefile.am         | 17 -----------------
>  src/meson.build         | 18 +++++++++++++++++-
>  4 files changed, 30 insertions(+), 18 deletions(-)
>  create mode 100644 scripts/check-augeas.sh

[...]

> @@ -857,3 +860,16 @@ test(
>    args: [ check_aclrules_prog.path(), files('remote/remote_protocol.x'), stateful_driver_source_files ],
>    env: runutf8,
>  )
> +
> +if augparse_prog.found()

Can't we use foreach on augeas_test_data and invoke the test
individually for each file rather than adding a script which does the
same?

> +  test(
> +    'check-augeas',
> +    check_augeas_prog,
> +    args: [
> +      augparse_prog.path(),
> +      meson.current_source_dir(),
> +      meson.current_build_dir(),
> +      augeas_test_data,
> +    ],
> +  )
> +endif
> -- 
> 2.26.2
> 




More information about the libvir-list mailing list