[libvirt PATCH] ci: move dco-check to a later stage

Ján Tomko jtomko at redhat.com
Tue Jul 28 09:39:10 UTC 2020


Be less hostile to developers and run the build jobs even
if the dco-check failed. That way they can test their own
"private" branches without a sign-off.

Also specify empty `needs` for it, since it does not depend
on any of the jobs in the container phase and can be run
right away.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
https://gitlab.com/jano.tomko/libvirt/-/pipelines/171532004

 .gitlab-ci.yml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 702198ec8e..b7a1609580 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -2,7 +2,6 @@ variables:
   GIT_DEPTH: 100
 
 stages:
-  - sanity_checks
   - containers
   - builds
 
@@ -479,8 +478,15 @@ potfile:
 # Skip on "libvirt" namespace, since we only need to run
 # this test on developer's personal forks from which
 # merge requests are submitted
+#
+# Put it in the same stage as other tests we expect to fail
+# because of developer's changes as to not frustrate them
+# with partial feedback, but run it as soon as the pipeline
+# starts, since it does not have any `needs` from the previous
+# stages.
 check-dco:
-  stage: sanity_checks
+  stage: builds
+  needs: []
   image: registry.gitlab.com/libvirt/libvirt-ci/check-dco:master
   script:
     - /check-dco
-- 
2.26.2




More information about the libvir-list mailing list