[PATCH v3 1/3 (for 6.6.0)] resctrl: Use exclusive lock for /sys/fs/resctrl

Martin Kletzander mkletzan at redhat.com
Wed Jul 29 13:04:32 UTC 2020

On Wed, Jul 29, 2020 at 02:09:20PM +0200, Andrea Bolognani wrote:
>On Wed, 2020-07-29 at 13:43 +0200, Martin Kletzander wrote:
>> That's the way it should've been all the time.  It was originally the case, but
>> then the rework to virFileFlock() made the function ambiguous when it was
>> created in commit 5a0a5f7fb5f5, and due to that it was misused in commit
>> 657ddeff2313 and since then the lock being taken was shared rather than
>> exclusive.
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/util/virresctrl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>Consider this
>  Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>and safe for freeze, but honestly this issue has been around for more
>than two years at this point so I'm not entirely convinced it can't
>just wait for the merge window to open again. Up to you.

I agree and I'm fine with that.

>Andrea Bolognani / Red Hat / Virtualization
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200729/368949f8/attachment-0001.sig>

More information about the libvir-list mailing list