[PATCH 07/24] qemu: domain: Add infrastructure passing in TLS key's decryption key via 'secret'

Eric Blake eblake at redhat.com
Thu Jul 2 18:56:54 UTC 2020


On 7/2/20 9:39 AM, Peter Krempa wrote:
> Store the required data in the private data of a storage source and
> ensure that the 'alias' of the secret is formatted in the status XML.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_domain.c                    | 10 +++++++++-
>   src/qemu/qemu_domain.h                    |  3 +++
>   tests/qemustatusxml2xmldata/modern-in.xml |  1 +
>   3 files changed, 13 insertions(+), 1 deletion(-)
> 

> +++ b/tests/qemustatusxml2xmldata/modern-in.xml
> @@ -336,6 +336,7 @@
>                   <secret type='auth' alias='test-auth-alias'/>
>                   <secret type='encryption' alias='test-encryption-alias'/>
>                   <secret type='httpcookie' alias='http-cookie-alias'/>
> +                <secret type='tlskey' alias='tls certificate key alias'/>

Why to the other elements use '-' but this one uses ' '?

Otherwise,
Reviewed-by: Eric Blake <eblake at redhat.com>

>                   <TLSx509 alias='transport-alias'/>
>                 </objects>
>               </privateData>
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list