[PATCH 16/24] docs: checkpoint: Convert XML documentation to RST
eblake at redhat.com
Thu Jul 2 19:35:53 UTC 2020
On 7/2/20 9:40 AM, Peter Krempa wrote:
> Switch to the new format for easier extension.
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> docs/formatcheckpoint.html.in | 198 ----------------------------------
> docs/formatcheckpoint.rst | 162 ++++++++++++++++++++++++++++
> 2 files changed, 162 insertions(+), 198 deletions(-)
> delete mode 100644 docs/formatcheckpoint.html.in
> create mode 100644 docs/formatcheckpoint.rst
Again, I'm not strong in .rst, but the conversion seems sane.
Reviewed-by: Eric Blake <eblake at redhat.com>
> +second full backup would require. Most disk checkpoints are created in
> +conjunction with a backup via ``virDomainBackupBegin()``, although a future API
> +addition of ``virDomainSnapshotCreateXML2()`` will also make this possible when
> +creating external snapshots; however, libvirt also exposes enough support to
> +create disk checkpoints independently from a backup operation via
> +``virDomainCheckpointCreateXML()`` since 5.6.0. Likewise, the creation of
> +checkpoints when external snapshots exist is currently forbidden, although
> +future work will make it possible to integrate these two concepts.
Not for this patch (which is just a reformat, not editing), but how
close are we to getting to these future additions (the notion of
atomically creating a checkpoint alongside the snapshot creation, as
well as all the work you did to enable checkpoints and snapshots together)?
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
More information about the libvir-list