[PATCH] qemuBuildMemoryBackendProps: Use boolean type for 'pmem' property

Ján Tomko jtomko at redhat.com
Wed Jul 8 09:20:54 UTC 2020

On a Wednesday in 2020, Ján Tomko wrote:
>On a Wednesday in 2020, Peter Krempa wrote:
>>Commit 82576d8f35e used a string "on" to enable the 'pmem' property.
>>This is okay for the command line visitor, but the property is declared
>>as boolean in qemu and thus it will not work when using QMP.
>>Modify the type to boolean. This changes the command line, but
>>fortunately the command line visitor in qemu parses both 'yes' and 'on'
>>as true for the property.
>>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>>src/qemu/qemu_command.c                                         | 2 +-
>>.../memory-hotplug-nvdimm-pmem.x86_64-latest.args               | 2 +-
>>2 files changed, 2 insertions(+), 2 deletions(-)

I meant to paste:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

somewhere in here.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200708/cb6f9907/attachment-0001.sig>

More information about the libvir-list mailing list