[libvirt PATCH] docs: kbase: Fix the libvirt-host-validate typo

Erik Skultety eskultet at redhat.com
Wed Jul 8 11:42:19 UTC 2020


On Wed, Jul 08, 2020 at 01:28:49PM +0200, Ján Tomko wrote:
> On a Wednesday in 2020, Erik Skultety wrote:
> > I overlooked this typo during review of 2c3ffa37.
>
> Please do not follow commit hashes directly by a period.
> * rephrase the sentence
> * just drop the period
> * include a separator like <>
> or put in into the Fixes: tag

I remember you used to oppose the idea of using the Fixes/Resolves tags
in commit messages and be quite adamant about it, so looks strange you would
suggest it. Anyhow, noted, I forgot that the period breaks the double click
selection of the hash.

Erik




More information about the libvir-list mailing list