[PATCH v3 2/2] conf: Set SPAPR TPM default to 2.0 and prevent 1.2 choice

Peter Krempa pkrempa at redhat.com
Wed Jul 8 15:16:49 UTC 2020


On Wed, Jul 08, 2020 at 10:49:39 -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb at linux.ibm.com>
> 
> The firmware (SLOF) on QEMU for ppc64 does not support TPM 1.2, so
> prevent the choice of TPM 1.2 when the SPAPR device model is chosen
> and use a default of '2.0' (TPM 2) for the backend.
> 
> Signed-off-by: Stefan Berger <stefanb at linux.ibm.com>
> ---
>  src/qemu/qemu_domain.c   | 8 ++++++--
>  src/qemu/qemu_validate.c | 6 ++++++
>  2 files changed, 12 insertions(+), 2 deletions(-)

I'm not familiar enough with ppc64 to review the claims, but the code
looks good to me.

If nobody objects

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list