[PATCH v3 2/2] conf: Set SPAPR TPM default to 2.0 and prevent 1.2 choice

Stefan Berger stefanb at linux.ibm.com
Wed Jul 8 15:24:20 UTC 2020


On 7/8/20 11:16 AM, Peter Krempa wrote:
> On Wed, Jul 08, 2020 at 10:49:39 -0400, Stefan Berger wrote:
>> From: Stefan Berger <stefanb at linux.ibm.com>
>>
>> The firmware (SLOF) on QEMU for ppc64 does not support TPM 1.2, so
>> prevent the choice of TPM 1.2 when the SPAPR device model is chosen
>> and use a default of '2.0' (TPM 2) for the backend.
>>
>> Signed-off-by: Stefan Berger <stefanb at linux.ibm.com>
>> ---
>>   src/qemu/qemu_domain.c   | 8 ++++++--
>>   src/qemu/qemu_validate.c | 6 ++++++
>>   2 files changed, 12 insertions(+), 2 deletions(-)
> I'm not familiar enough with ppc64 to review the claims, but the code
> looks good to me.
>
> If nobody objects
>
> Reviewed-by: Peter Krempa <pkrempa at redhat.com>
>
This addresses this BZ: 
https://bugzilla.linux.ibm.com/show_bug.cgi?id=182797   (last comment)


I cannot push to the repo. Can you?






More information about the libvir-list mailing list