[libvirt PATCH] docs: kbase: Fix the libvirt-host-validate typo

Ján Tomko jtomko at redhat.com
Thu Jul 9 16:14:17 UTC 2020

On a Wednesday in 2020, Erik Skultety wrote:
>On Wed, Jul 08, 2020 at 01:28:49PM +0200, Ján Tomko wrote:
>> On a Wednesday in 2020, Erik Skultety wrote:
>> > I overlooked this typo during review of 2c3ffa37.
>> Please do not follow commit hashes directly by a period.
>> * rephrase the sentence
>> * just drop the period
>> * include a separator like <>
>> or put in into the Fixes: tag
>I remember you used to oppose the idea of using the Fixes/Resolves tags
>in commit messages and be quite adamant about it,

I objected to their usage with links to bugzilla, since the word seems
redundant in combination with a bugzilla link (especially since it is
only intended for human consumption). Or, if you say 'Resolves'
on a preparatory patch, you're actually lying in the current commit

Plain https: links mess with git's interpret-trailers functionality,
but that can be worked around in your .gitconfig:
[trailer "https"]
         key = https:
         ifExists = doNothing

With commit message IDs, if you dropped a plain one without a context,
I would not know whether you find a bug in it, or just took it as an

>so looks strange you would suggest it.

I've known you for a few years now, surely there would be other things
by now I've had a change of heart about. :)


>Anyhow, noted, I forgot that the period breaks the double click
>selection of the hash.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200709/f0e6881f/attachment-0001.sig>

More information about the libvir-list mailing list