[PATCH] Add a check attribute on the mac address element

Michal Privoznik mprivozn at redhat.com
Mon Jul 13 13:38:25 UTC 2020

On 7/13/20 2:15 PM, Daniel P. Berrangé wrote:
> On Mon, Jul 13, 2020 at 02:08:59PM +0200, Michal Privoznik wrote:

>> Pino, you have more experience with ESX than I do, do you know whether we
>> could do the switch to mark MAC addresses static/generated according to
>> @mac_generated?
> That's an internal thing though - if we want to support that properly for
> ESX, then I think we need to make that an explicit type="static|generated"
> attribute. In ESX there are different ranges you need to use for static vs
> generated tooo.

Indeed there are. So far virVMXFormatEthernet() puts static/generated 
into the config based on these ranges.
Seems like there is simple way out and we need to have the argument. 
Bastien, can you please post v2 where the attribute is renamed to @type 
and accepts static/generated values?


More information about the libvir-list mailing list