[libvirt PATCH 000/351] port libvirt to Meson build system

Jiri Denemark jdenemar at redhat.com
Thu Jul 16 18:36:42 UTC 2020

On Thu, Jul 16, 2020 at 15:47:48 +0200, Pavel Hrdina wrote:
> On Thu, Jul 16, 2020 at 02:01:34PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote:
> > > Patches are available in my Gitlab repo as well:
> > > 
> > >     git clone -b meson https://gitlab.com/phrdina/libvirt.git
> > > 
> > > and link to Giltab pipeline:
> > > 
> > >     https://gitlab.com/phrdina/libvirt/-/pipelines/167276632
> > > 
> > > The pipeline is not for the latest version is I tweaked some commit
> > > messages.
> > 
> > BTW, assuming we do positively review this, we need to consider when
> > is a good time to merge. Having positive CI builds is good, but that
> > only tells us that a build succeeded, it doesn't tell us that all the
> > right features are enabled. I think it is inevitable that we are going
> > to break stuff and miss it in review.  So the prudent approach would
> > be to merge this series immediately after a release, so that we have
> > as much of a full month available as possible for debugging post-merge.
> Completely agree here. I wanted to post the patches with some time
> before next release so the review can catch the main and obvious issues
> or suggest different approach to some parts of the new build system.
> There were also privet suggestions to push it even without review right
> after release is done and deal with the issues before next release.

This was more a joke than a serious suggestion. But I basically wanted
to express what Daniel said already. We will face bugs that won't be
caught by any review and it will take time to find and fix them. I agree
with the plan to push this after the release.


More information about the libvir-list mailing list