[libvirt PATCH] Partially revert "qemu: fix missing error reports in capabilities probing"
mprivozn at redhat.com
Fri Jul 17 08:03:49 UTC 2020
On 7/15/20 5:08 PM, Daniel P. Berrangé wrote:
> This partially reverts commit 5331c4804f4f419b9e75741084f926e52413d3a1.
> The original commit mistakenly thought virFileCacheLookup did not set
> an error. In fact the only case it doesn't set an error for is when
> the cache key is NULL. This in fact the fault of the caller for passing
> an invalid cache key, so doesn't need to be handled.
> This caller bug was fixed by checking for a NULL binary in the
> virQEMUCapsCacheLookupDefault method.
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> src/qemu/qemu_capabilities.c | 5 -----
> src/qemu/qemu_domain.c | 4 +---
> 2 files changed, 1 insertion(+), 8 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
More information about the libvir-list