[libvirt PATCH 000/351] port libvirt to Meson build system

Peter Krempa pkrempa at redhat.com
Fri Jul 17 09:21:56 UTC 2020


On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:

[...]

Tests fail when building with clang:

built as:

 CC=clang meson clang ~/libvirt
 cd clang
 ninja
 ninja test


Looking at the test output (pasted below) you didn't faithfully
reproduce the skipping of symbol file tests which have different
ordering when the code is compiled with clang.

Test output:

[0/1] Running all tests.
  1/154 check-aclperms                  OK             0.06s
  2/154 check-symfile                   OK             0.08s
  3/154 check-admin-symfile             OK             0.04s
  4/154 check-symsorting                OK             0.04s
  5/154 check-admin-symsorting          OK             0.03s
  6/154 check-drivername                OK             0.04s
  7/154 check-admin-drivername          OK             0.06s
  8/154 check-driverimpls               OK             0.22s
  9/154 check-aclrules                  OK             0.24s
 10/154 check-augeas                    OK             0.08s
 11/154 check-virnetprotocol            FAIL           0.05s (exit status 1)
 12/154 check-virkeepaliveprotocol      OK             0.05s
 13/154 check-remote_protocol           FAIL           0.10s (exit status 1)
 14/154 check-qemu_protocol             FAIL           0.05s (exit status 1)
 15/154 check-lxc_protocol              FAIL           0.05s (exit status 1)
 16/154 check-admin_protocol            FAIL           0.05s (exit status 1)
 17/154 check-lock_protocol             FAIL           0.04s (exit status 1)
 18/154 check-lxc_monitor_protocol      FAIL           0.04s (exit status 1)
 19/154 commandtest                     OK             0.42s
 20/154 cputest                         OK             0.77s
 21/154 domaincapstest                  OK             0.32s
 22/154 domainconftest                  OK             0.05s
 23/154 genericxml2xmltest              OK             0.11s
 24/154 interfacexml2xmltest            OK             0.04s
 25/154 metadatatest                    OK             0.03s
 26/154 networkxml2xmlupdatetest        OK             0.04s
 27/154 nodedevxml2xmltest              OK             0.02s
 28/154 nwfilterxml2xmltest             OK             0.03s
 29/154 objecteventtest                 OK             0.04s
 30/154 seclabeltest                    OK             0.02s
 31/154 secretxml2xmltest               OK             0.02s
 32/154 shunloadtest                    OK             0.02s
 33/154 sockettest                      OK             0.03s
 34/154 storagevolxml2xmltest           OK             0.02s
 35/154 sysinfotest                     OK             0.03s
 36/154 utiltest                        OK             0.05s
 37/154 viralloctest                    OK             0.02s
 38/154 virauthconfigtest               OK             0.02s
 39/154 virbitmaptest                   OK             0.02s
 40/154 virbuftest                      OK             0.02s
 41/154 vircapstest                     OK             0.02s
 42/154 vircgrouptest                   OK             0.05s
 43/154 virconftest                     OK             0.04s
 44/154 vircryptotest                   OK             0.03s
 45/154 virendiantest                   OK             0.03s
 46/154 virerrortest                    OK             0.03s
 47/154 virfilecachetest                OK             0.04s
 48/154 virfiletest                     OK             0.03s
 49/154 virfirewalltest                 OK             0.04s
 50/154 virhashtest                     OK             0.02s
 51/154 virhostcputest                  OK             0.05s
 52/154 virhostdevtest                  OK             0.11s
 53/154 viriscsitest                    OK             0.03s
 54/154 virkeycodetest                  OK             0.02s
 55/154 virkmodtest                     OK             0.03s
 56/154 virlockspacetest                OK             0.02s
 57/154 virlogtest                      OK             0.03s
 58/154 virnetdevtest                   OK             0.03s
 59/154 virnetworkportxml2xmltest       OK             0.03s
 60/154 virnwfilterbindingxml2xmltest   OK             0.02s
 61/154 virpcitest                      OK             0.04s
 62/154 virportallocatortest            OK             0.04s
 63/154 virrotatingfiletest             OK             0.04s
 64/154 virschematest                   OK             1.05s
 65/154 virshtest                       OK             1.10s
 66/154 virstringtest                   OK             0.02s
 67/154 virtimetest                     OK             0.02s
 68/154 virtypedparamtest               OK             0.03s
 69/154 viruritest                      OK             0.03s
 70/154 vshtabletest                    OK             0.01s
 71/154 fchosttest                      OK             0.04s
 72/154 scsihosttest                    OK             0.02s
 73/154 vircaps2xmltest                 OK             0.03s
 74/154 virnetdevbandwidthtest          OK             0.03s
 75/154 virresctrltest                  OK             0.03s
 76/154 virscsitest                     OK             0.03s
 77/154 virusbtest                      OK             0.04s
 78/154 virdbustest                     OK             0.02s
 79/154 virsystemdtest                  OK             0.03s
 80/154 virpolkittest                   OK             0.03s
 81/154 esxutilstest                    OK             0.01s
 82/154 eventtest                       OK             0.44s
 83/154 fdstreamtest                    OK             0.02s
 84/154 virdriverconnvalidatetest       OK             0.02s
 85/154 virdrivermoduletest             OK             0.05s
 86/154 libxlxml2domconfigtest          OK             0.05s
 87/154 xlconfigtest                    OK             0.06s
 88/154 xmconfigtest                    OK             0.05s
 89/154 lxcconf2xmltest                 OK             0.02s
 90/154 lxcxml2xmltest                  OK             0.03s
 91/154 networkxml2conftest             OK             0.03s
 92/154 networkxml2firewalltest         OK             0.03s
 93/154 networkxml2xmltest              OK             0.03s
 94/154 nodedevmdevctltest              OK             0.02s
 95/154 nsstest                         OK             0.05s
 96/154 nssguesttest                    OK             0.03s
 97/154 nwfilterebiptablestest          OK             0.02s
 98/154 nwfilterxml2firewalltest        OK             0.03s
 99/154 openvzutilstest                 OK             0.03s
100/154 qemuagenttest                   OK             0.03s
101/154 qemublocktest                   OK             0.13s
102/154 qemucapabilitiestest            OK             1.28s
103/154 qemucaps2xmltest                OK             0.13s
104/154 qemucommandutiltest             OK             0.02s
105/154 qemudomaincheckpointxml2xmltest OK             0.24s
106/154 qemudomainsnapshotxml2xmltest   OK             0.02s
107/154 qemufirmwaretest                OK             0.02s
108/154 qemuhotplugtest                 OK             0.38s
109/154 qemumemlocktest                 OK             0.08s
110/154 qemumigparamstest               OK             0.05s
111/154 qemumonitorjsontest             OK             0.38s
112/154 qemusecuritytest                OK             0.88s
113/154 qemuvhostusertest               OK             0.03s
114/154 qemuxml2argvtest                OK             4.69s
115/154 qemuxml2xmltest                 OK             1.78s
116/154 virnetdaemontest                OK             0.08s
117/154 virnetmessagetest               OK             0.02s
118/154 virnetserverclienttest          OK             0.05s
119/154 virnetsockettest                OK             0.13s
120/154 virnettlscontexttest            OK             0.33s
121/154 virnettlssessiontest            OK             0.48s
122/154 storagepoolcapstest             OK             0.04s
123/154 storagepoolxml2argvtest         OK             0.07s
124/154 storagepoolxml2xmltest          OK             0.07s
125/154 storagevolxml2argvtest          OK             0.04s
126/154 virstorageutiltest              OK             0.02s
127/154 virstoragetest                  OK             0.93s
128/154 storagebackendsheepdogtest      OK             0.03s
129/154 vboxsnapshotxmltest             OK             0.04s
130/154 vmwarevertest                   OK             0.02s
131/154 vmx2xmltest                     OK             0.04s
132/154 xml2vmxtest                     OK             0.04s
133/154 virjsontest                     OK             0.02s
134/154 virmacmaptest                   OK             0.04s
135/154 virnetdevopenvswitchtest        OK             0.02s
136/154 libvirtd-fail                   OK             0.04s
137/154 libvirtd-pool                   OK             0.07s
138/154 virsh-auth                      OK             0.07s
139/154 virsh-checkpoint                OK             0.33s
140/154 virsh-cpuset                    OK             0.07s
141/154 virsh-define-dev-segfault       OK             0.07s
142/154 virsh-int-overflow              OK             0.04s
143/154 virsh-optparse                  SKIP           0.03s
144/154 virsh-read-bufsiz               OK             0.12s
145/154 virsh-read-non-seekable         OK             0.07s
146/154 virsh-schedinfo                 OK             0.04s
147/154 virsh-self-test                 OK             0.07s
148/154 virsh-snapshot                  OK             0.37s
149/154 virsh-start                     OK             0.08s
150/154 virsh-undefine                  OK             0.12s
151/154 virsh-uriprecedence             OK             0.23s
152/154 virsh-vcpupin                   OK             0.22s
153/154 virt-admin-self-test            OK             0.07s
154/154 check-html                      OK             0.07s

Ok:                 146
Expected Fail:      0
Fail:               7
Unexpected Pass:    0
Skipped:            1
Timeout:            0


The output from the failed tests:

 11/154 check-virnetprotocol            FAIL           0.05s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py virnetprotocol virt_net_rpc /home/pipo/build/libvirt/meson/clang/src/rpc /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/virnetprotocol-structs
--- stdout ---
--- /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/virnetprotocol-structs	2020-01-29 15:18:11.000000000 +0100
+++ -	2020-07-17 11:18:24.972477362 +0200
@@ -13,14 +13,6 @@
         VIR_NET_ERROR = 1,
         VIR_NET_CONTINUE = 2,
 };
-struct virNetMessageHeader {
-        u_int                      prog;
-        u_int                      vers;
-        int                        proc;
-        virNetMessageType          type;
-        u_int                      serial;
-        virNetMessageStatus        status;
-};
 struct virNetMessageNonnullDomain {
         virNetMessageNonnullString name;
         virNetMessageUUID          uuid;
@@ -30,6 +22,14 @@
         virNetMessageNonnullString name;
         virNetMessageUUID          uuid;
 };
+struct virNetMessageHeader {
+        u_int                      prog;
+        u_int                      vers;
+        int                        proc;
+        virNetMessageType          type;
+        u_int                      serial;
+        virNetMessageStatus        status;
+};
 struct virNetMessageError {
         int                        code;
         int                        domain;
-------

 13/154 check-remote_protocol           FAIL           0.10s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py remote_protocol virt_remote_driver /home/pipo/build/libvirt/meson/clang/src/remote /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/remote_protocol-structs
--- Listing only the last 100 lines from a long log. ---
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BLOCK_JOB = 326,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DISK_CHANGE = 327,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TRAY_CHANGE = 328,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMWAKEUP = 329,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND = 330,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_BALLOON_CHANGE = 331,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_PMSUSPEND_DISK = 332,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333,
-        REMOTE_PROC_DOMAIN_CORE_DUMP_WITH_FORMAT = 334,
-        REMOTE_PROC_DOMAIN_FSFREEZE = 335,
-        REMOTE_PROC_DOMAIN_FSTHAW = 336,
-        REMOTE_PROC_DOMAIN_GET_TIME = 337,
-        REMOTE_PROC_DOMAIN_SET_TIME = 338,
-        REMOTE_PROC_DOMAIN_EVENT_BLOCK_JOB_2 = 339,
-        REMOTE_PROC_NODE_GET_FREE_PAGES = 340,
-        REMOTE_PROC_NETWORK_GET_DHCP_LEASES = 341,
-        REMOTE_PROC_CONNECT_GET_DOMAIN_CAPABILITIES = 342,
-        REMOTE_PROC_DOMAIN_OPEN_GRAPHICS_FD = 343,
-        REMOTE_PROC_CONNECT_GET_ALL_DOMAIN_STATS = 344,
-        REMOTE_PROC_DOMAIN_BLOCK_COPY = 345,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE = 346,
-        REMOTE_PROC_NODE_ALLOC_PAGES = 347,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_AGENT_LIFECYCLE = 348,
-        REMOTE_PROC_DOMAIN_GET_FSINFO = 349,
-        REMOTE_PROC_DOMAIN_DEFINE_XML_FLAGS = 350,
-        REMOTE_PROC_DOMAIN_GET_IOTHREAD_INFO = 351,
-        REMOTE_PROC_DOMAIN_PIN_IOTHREAD = 352,
-        REMOTE_PROC_DOMAIN_INTERFACE_ADDRESSES = 353,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_ADDED = 354,
-        REMOTE_PROC_DOMAIN_ADD_IOTHREAD = 355,
-        REMOTE_PROC_DOMAIN_DEL_IOTHREAD = 356,
-        REMOTE_PROC_DOMAIN_SET_USER_PASSWORD = 357,
-        REMOTE_PROC_DOMAIN_RENAME = 358,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_MIGRATION_ITERATION = 359,
-        REMOTE_PROC_CONNECT_REGISTER_CLOSE_CALLBACK = 360,
-        REMOTE_PROC_CONNECT_UNREGISTER_CLOSE_CALLBACK = 361,
-        REMOTE_PROC_CONNECT_EVENT_CONNECTION_CLOSED = 362,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_JOB_COMPLETED = 363,
-        REMOTE_PROC_DOMAIN_MIGRATE_START_POST_COPY = 364,
-        REMOTE_PROC_DOMAIN_GET_PERF_EVENTS = 365,
-        REMOTE_PROC_DOMAIN_SET_PERF_EVENTS = 366,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVAL_FAILED = 367,
-        REMOTE_PROC_CONNECT_STORAGE_POOL_EVENT_REGISTER_ANY = 368,
-        REMOTE_PROC_CONNECT_STORAGE_POOL_EVENT_DEREGISTER_ANY = 369,
-        REMOTE_PROC_STORAGE_POOL_EVENT_LIFECYCLE = 370,
-        REMOTE_PROC_DOMAIN_GET_GUEST_VCPUS = 371,
-        REMOTE_PROC_DOMAIN_SET_GUEST_VCPUS = 372,
-        REMOTE_PROC_STORAGE_POOL_EVENT_REFRESH = 373,
-        REMOTE_PROC_CONNECT_NODE_DEVICE_EVENT_REGISTER_ANY = 374,
-        REMOTE_PROC_CONNECT_NODE_DEVICE_EVENT_DEREGISTER_ANY = 375,
-        REMOTE_PROC_NODE_DEVICE_EVENT_LIFECYCLE = 376,
-        REMOTE_PROC_NODE_DEVICE_EVENT_UPDATE = 377,
-        REMOTE_PROC_STORAGE_VOL_GET_INFO_FLAGS = 378,
-        REMOTE_PROC_DOMAIN_EVENT_CALLBACK_METADATA_CHANGE = 379,
-        REMOTE_PROC_CONNECT_SECRET_EVENT_REGISTER_ANY = 380,
-        REMOTE_PROC_CONNECT_SECRET_EVENT_DEREGISTER_ANY = 381,
-        REMOTE_PROC_SECRET_EVENT_LIFECYCLE = 382,
-        REMOTE_PROC_SECRET_EVENT_VALUE_CHANGED = 383,
-        REMOTE_PROC_DOMAIN_SET_VCPU = 384,
-        REMOTE_PROC_DOMAIN_EVENT_BLOCK_THRESHOLD = 385,
-        REMOTE_PROC_DOMAIN_SET_BLOCK_THRESHOLD = 386,
-        REMOTE_PROC_DOMAIN_MIGRATE_GET_MAX_DOWNTIME = 387,
-        REMOTE_PROC_DOMAIN_MANAGED_SAVE_GET_XML_DESC = 388,
-        REMOTE_PROC_DOMAIN_MANAGED_SAVE_DEFINE_XML = 389,
-        REMOTE_PROC_DOMAIN_SET_LIFECYCLE_ACTION = 390,
-        REMOTE_PROC_STORAGE_POOL_LOOKUP_BY_TARGET_PATH = 391,
-        REMOTE_PROC_DOMAIN_DETACH_DEVICE_ALIAS = 392,
-        REMOTE_PROC_CONNECT_COMPARE_HYPERVISOR_CPU = 393,
-        REMOTE_PROC_CONNECT_BASELINE_HYPERVISOR_CPU = 394,
-        REMOTE_PROC_NODE_GET_SEV_INFO = 395,
-        REMOTE_PROC_DOMAIN_GET_LAUNCH_SECURITY_INFO = 396,
-        REMOTE_PROC_NWFILTER_BINDING_LOOKUP_BY_PORT_DEV = 397,
-        REMOTE_PROC_NWFILTER_BINDING_GET_XML_DESC = 398,
-        REMOTE_PROC_NWFILTER_BINDING_CREATE_XML = 399,
-        REMOTE_PROC_NWFILTER_BINDING_DELETE = 400,
-        REMOTE_PROC_CONNECT_LIST_ALL_NWFILTER_BINDINGS = 401,
-        REMOTE_PROC_DOMAIN_SET_IOTHREAD_PARAMS = 402,
-        REMOTE_PROC_CONNECT_GET_STORAGE_POOL_CAPABILITIES = 403,
-        REMOTE_PROC_NETWORK_LIST_ALL_PORTS = 404,
-        REMOTE_PROC_NETWORK_PORT_LOOKUP_BY_UUID = 405,
-        REMOTE_PROC_NETWORK_PORT_CREATE_XML = 406,
-        REMOTE_PROC_NETWORK_PORT_GET_PARAMETERS = 407,
-        REMOTE_PROC_NETWORK_PORT_SET_PARAMETERS = 408,
-        REMOTE_PROC_NETWORK_PORT_GET_XML_DESC = 409,
-        REMOTE_PROC_NETWORK_PORT_DELETE = 410,
-        REMOTE_PROC_DOMAIN_CHECKPOINT_CREATE_XML = 411,
-        REMOTE_PROC_DOMAIN_CHECKPOINT_GET_XML_DESC = 412,
-        REMOTE_PROC_DOMAIN_LIST_ALL_CHECKPOINTS = 413,
-        REMOTE_PROC_DOMAIN_CHECKPOINT_LIST_ALL_CHILDREN = 414,
-        REMOTE_PROC_DOMAIN_CHECKPOINT_LOOKUP_BY_NAME = 415,
-        REMOTE_PROC_DOMAIN_CHECKPOINT_GET_PARENT = 416,
-        REMOTE_PROC_DOMAIN_CHECKPOINT_DELETE = 417,
-        REMOTE_PROC_DOMAIN_GET_GUEST_INFO = 418,
-        REMOTE_PROC_CONNECT_SET_IDENTITY = 419,
-        REMOTE_PROC_DOMAIN_AGENT_SET_RESPONSE_TIMEOUT = 420,
-        REMOTE_PROC_DOMAIN_BACKUP_BEGIN = 421,
-        REMOTE_PROC_DOMAIN_BACKUP_GET_XML_DESC = 422,
-};
-------

 14/154 check-qemu_protocol             FAIL           0.05s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py qemu_protocol virt_remote_driver /home/pipo/build/libvirt/meson/clang/src/remote /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/qemu_protocol-structs
--- stdout ---
--- /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/qemu_protocol-structs	2020-01-29 15:18:11.000000000 +0100
+++ -	2020-07-17 11:18:24.996893209 +0200
@@ -4,6 +4,14 @@
         remote_uuid                uuid;
         int                        id;
 };
+enum qemu_procedure {
+        QEMU_PROC_DOMAIN_MONITOR_COMMAND = 1,
+        QEMU_PROC_DOMAIN_ATTACH = 2,
+        QEMU_PROC_DOMAIN_AGENT_COMMAND = 3,
+        QEMU_PROC_CONNECT_DOMAIN_MONITOR_EVENT_REGISTER = 4,
+        QEMU_PROC_CONNECT_DOMAIN_MONITOR_EVENT_DEREGISTER = 5,
+        QEMU_PROC_DOMAIN_MONITOR_EVENT = 6,
+};
 struct qemu_domain_monitor_command_args {
         remote_nonnull_domain      dom;
         remote_nonnull_string      cmd;
@@ -47,11 +55,3 @@
         u_int                      micros;
         remote_string              details;
 };
-enum qemu_procedure {
-        QEMU_PROC_DOMAIN_MONITOR_COMMAND = 1,
-        QEMU_PROC_DOMAIN_ATTACH = 2,
-        QEMU_PROC_DOMAIN_AGENT_COMMAND = 3,
-        QEMU_PROC_CONNECT_DOMAIN_MONITOR_EVENT_REGISTER = 4,
-        QEMU_PROC_CONNECT_DOMAIN_MONITOR_EVENT_DEREGISTER = 5,
-        QEMU_PROC_DOMAIN_MONITOR_EVENT = 6,
-};
-------

 15/154 check-lxc_protocol              FAIL           0.05s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py lxc_protocol virt_remote_driver /home/pipo/build/libvirt/meson/clang/src/remote /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/lxc_protocol-structs
--- stdout ---
--- /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/lxc_protocol-structs	2020-01-29 15:18:11.000000000 +0100
+++ -	2020-07-17 11:18:24.996089241 +0200
@@ -4,10 +4,10 @@
         remote_uuid                uuid;
         int                        id;
 };
+enum lxc_procedure {
+        LXC_PROC_DOMAIN_OPEN_NAMESPACE = 1,
+};
 struct lxc_domain_open_namespace_args {
         remote_nonnull_domain      dom;
         u_int                      flags;
 };
-enum lxc_procedure {
-        LXC_PROC_DOMAIN_OPEN_NAMESPACE = 1,
-};
-------

 16/154 check-admin_protocol            FAIL           0.05s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py admin_protocol virt_admin_driver /home/pipo/build/libvirt/meson/clang/src/admin /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/admin_protocol-structs
--- Listing only the last 100 lines from a long log. ---
 struct admin_typed_param {
         admin_nonnull_string       field;
         admin_typed_param_value    value;
 };
-struct admin_nonnull_server {
-        admin_nonnull_string       name;
-};
-struct admin_nonnull_client {
-        admin_nonnull_server       srv;
-        uint64_t                   id;
-        int64_t                    timestamp;
-        u_int                      transport;
-};
 struct admin_connect_open_args {
         u_int                      flags;
 };
@@ -39,8 +58,6 @@
                 u_int              servers_len;
                 admin_nonnull_server * servers_val;
         } servers;
-        u_int                      ret;
-};
 struct admin_connect_lookup_server_args {
         admin_nonnull_string       name;
         u_int                      flags;
@@ -57,15 +74,12 @@
                 u_int              params_len;
                 admin_typed_param * params_val;
         } params;
-};
 struct admin_server_set_threadpool_parameters_args {
         admin_nonnull_server       srv;
         struct {
                 u_int              params_len;
                 admin_typed_param * params_val;
         } params;
-        u_int                      flags;
-};
 struct admin_server_list_clients_args {
         admin_nonnull_server       srv;
         u_int                      need_results;
@@ -76,8 +90,6 @@
                 u_int              clients_len;
                 admin_nonnull_client * clients_val;
         } clients;
-        u_int                      ret;
-};
 struct admin_server_lookup_client_args {
         admin_nonnull_server       srv;
         uint64_t                   id;
@@ -95,7 +107,6 @@
                 u_int              params_len;
                 admin_typed_param * params_val;
         } params;
-};
 struct admin_client_close_args {
         admin_nonnull_client       clnt;
         u_int                      flags;
@@ -109,15 +120,12 @@
                 u_int              params_len;
                 admin_typed_param * params_val;
         } params;
-};
 struct admin_server_set_client_limits_args {
         admin_nonnull_server       srv;
         struct {
                 u_int              params_len;
                 admin_typed_param * params_val;
         } params;
-        u_int                      flags;
-};
 struct admin_server_update_tls_files_args {
         admin_nonnull_server       srv;
         u_int                      flags;
@@ -144,23 +152,3 @@
         admin_string               filters;
         u_int                      flags;
 };
-enum admin_procedure {
-        ADMIN_PROC_CONNECT_OPEN = 1,
-        ADMIN_PROC_CONNECT_CLOSE = 2,
-        ADMIN_PROC_CONNECT_GET_LIB_VERSION = 3,
-        ADMIN_PROC_CONNECT_LIST_SERVERS = 4,
-        ADMIN_PROC_CONNECT_LOOKUP_SERVER = 5,
-        ADMIN_PROC_SERVER_GET_THREADPOOL_PARAMETERS = 6,
-        ADMIN_PROC_SERVER_SET_THREADPOOL_PARAMETERS = 7,
-        ADMIN_PROC_SERVER_LIST_CLIENTS = 8,
-        ADMIN_PROC_SERVER_LOOKUP_CLIENT = 9,
-        ADMIN_PROC_CLIENT_GET_INFO = 10,
-        ADMIN_PROC_CLIENT_CLOSE = 11,
-        ADMIN_PROC_SERVER_GET_CLIENT_LIMITS = 12,
-        ADMIN_PROC_SERVER_SET_CLIENT_LIMITS = 13,
-        ADMIN_PROC_CONNECT_GET_LOGGING_OUTPUTS = 14,
-        ADMIN_PROC_CONNECT_GET_LOGGING_FILTERS = 15,
-        ADMIN_PROC_CONNECT_SET_LOGGING_OUTPUTS = 16,
-        ADMIN_PROC_CONNECT_SET_LOGGING_FILTERS = 17,
-        ADMIN_PROC_SERVER_UPDATE_TLS_FILES = 18,
-};
-------

 17/154 check-lock_protocol             FAIL           0.04s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py lock_protocol lockd_impl /home/pipo/build/libvirt/meson/clang/src/locking /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/lock_protocol-structs
--- stdout ---
--- /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/lock_protocol-structs	2020-01-29 15:18:11.000000000 +0100
+++ -	2020-07-17 11:18:25.001138489 +0200
@@ -1,4 +1,14 @@
 /* -*- c -*- */
+enum virLockSpaceProtocolProcedure {
+        VIR_LOCK_SPACE_PROTOCOL_PROC_REGISTER = 1,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_RESTRICT = 2,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_NEW = 3,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_CREATE_RESOURCE = 4,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_DELETE_RESOURCE = 5,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_ACQUIRE_RESOURCE = 6,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_RELEASE_RESOURCE = 7,
+        VIR_LOCK_SPACE_PROTOCOL_PROC_CREATE_LOCKSPACE = 8,
+};
 struct virLockSpaceProtocolOwner {
         virLockSpaceProtocolUUID   uuid;
         virLockSpaceProtocolNonNullString name;
@@ -39,13 +49,3 @@
 struct virLockSpaceProtocolCreateLockSpaceArgs {
         virLockSpaceProtocolNonNullString path;
 };
-enum virLockSpaceProtocolProcedure {
-        VIR_LOCK_SPACE_PROTOCOL_PROC_REGISTER = 1,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_RESTRICT = 2,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_NEW = 3,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_CREATE_RESOURCE = 4,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_DELETE_RESOURCE = 5,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_ACQUIRE_RESOURCE = 6,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_RELEASE_RESOURCE = 7,
-        VIR_LOCK_SPACE_PROTOCOL_PROC_CREATE_LOCKSPACE = 8,
-};
-------

 18/154 check-lxc_monitor_protocol      FAIL           0.04s (exit status 1)

--- command ---
09:18:24 LANG='C' LC_CTYPE='en_US.UTF-8' LC_ALL='' /bin/python3 /home/pipo/libvirt/scripts/check-remote-protocol.py lxc_monitor_protocol virt_driver_lxc_impl /home/pipo/build/libvirt/meson/clang/src/lxc /bin/pdwtags /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/lxc_monitor_protocol-structs
--- stdout ---
--- /home/pipo/build/libvirt/meson/clang/../../../../libvirt/src/lxc_monitor_protocol-structs	2020-01-29 15:18:11.000000000 +0100
+++ -	2020-07-17 11:18:24.999930097 +0200
@@ -4,13 +4,13 @@
         VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN = 1,
         VIR_LXC_MONITOR_EXIT_STATUS_REBOOT = 2,
 };
+enum virLXCMonitorProcedure {
+        VIR_LXC_MONITOR_PROC_EXIT_EVENT = 1,
+        VIR_LXC_MONITOR_PROC_INIT_EVENT = 2,
+};
 struct virLXCMonitorExitEventMsg {
         virLXCMonitorExitStatus    status;
 };
 struct virLXCMonitorInitEventMsg {
         uint64_t                   initpid;
 };
-enum virLXCMonitorProcedure {
-        VIR_LXC_MONITOR_PROC_EXIT_EVENT = 1,
-        VIR_LXC_MONITOR_PROC_INIT_EVENT = 2,
-};
-------




More information about the libvir-list mailing list