[libvirt PATCH] spec: Drop explicit dependency on ncurses

Andrea Bolognani abologna at redhat.com
Sat Jul 18 22:54:43 UTC 2020


We don't actually use ncurses directly: readline needs it, but
that's a readline implementation detail and not something that we
should concern ourselves with.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
Test pipeline where I've tweaked all CI environments so that ncurses
is not explicitly installed, and in the case of macOS pkg-config is
not configured in a way that allows it to locate ncurses.pc:

  https://gitlab.com/abologna/libvirt/-/pipelines/168175622

 libvirt.spec.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f335a7e06e..029159269b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -288,7 +288,6 @@ BuildRequires: readline-devel
 %if %{with_bash_completion}
 BuildRequires: bash-completion >= 2.0
 %endif
-BuildRequires: ncurses-devel
 BuildRequires: gettext
 BuildRequires: libtasn1-devel
 BuildRequires: gnutls-devel
@@ -901,7 +900,6 @@ capabilities of VirtualBox
 Summary: Client side utilities of the libvirt library
 Requires: %{name}-libs = %{version}-%{release}
 Requires: readline
-Requires: ncurses
 # Needed by /usr/libexec/libvirt-guests.sh script.
 Requires: gettext
 # Needed by virt-pki-validate script.
-- 
2.25.4




More information about the libvir-list mailing list