[PATCH 04/10] qemuProcessHandleBlockThreshold: Report correct indexes

Eric Blake eblake at redhat.com
Mon Jul 20 21:00:08 UTC 2020

On 7/15/20 8:10 AM, Peter Krempa wrote:
> The index returned by qemuDomainDiskLookupByNodename is the position in
> the backing chain rather than the index we report in the XML.
> Since with -blockdev they differ now and additionally the disk source
> also has an index we need to fix the 'threshold' evens we report:


> 1) If it's the top level image we must always trigger the event without
>     any suffix as we did until now
> 2) We must report the correct index
> 3) We must report the correct index also for the top level image, when
>     blockdev is used.
> This means that we need to potentially emit 2 events, one for the device
> without the index and then when blockdev is used and the top level image
> has an idex we must do it also with the index.


> This will fix it for blockdev cases, while also not removing previous
> semantics.
> https://bugzilla.redhat.com/show_bug.cgi?id=1857204
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_process.c | 26 ++++++++++++++++++--------
>   1 file changed, 18 insertions(+), 8 deletions(-)

With typos fixed,
Reviewed-by: Eric Blake <eblake at redhat.com>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

More information about the libvir-list mailing list