[PATCH 09/10] qemuDomainGetStorageSourceByDevstr: Look also in 'mirror' chain

Eric Blake eblake at redhat.com
Mon Jul 20 21:07:25 UTC 2020


On 7/15/20 8:10 AM, Peter Krempa wrote:
> A disk can have a mirror, look also in it's backing chain.

its

(it's is only valid when you can replace with 'it is')

> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_domain.c | 13 +++++++++----
>   1 file changed, 9 insertions(+), 4 deletions(-)
> 

Reviewed-by: Eric Blake <eblake at redhat.com>

Hmm, when doing a pull-mode backup, do we ever want a write-threshold on 
the temporary image?  Or is this only for actual block-copy mirroring, 
and not backups?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list