[PATCH V2] qemu: pre-create the dbus directory in qemuStateInitialize

Pino Toscano ptoscano at redhat.com
Wed Jul 22 05:36:45 UTC 2020

On Wednesday, 22 July 2020 04:09:24 CEST Bihong Yu wrote:
> +    if (virDirCreate(cfg->dbusStateDir, 0770, cfg->user, cfg->group,
> +                     VIR_DIR_CREATE_ALLOW_EXIST) < 0) {
> +        virReportSystemError(errno, _("Failed to create dbus state dir %s"),
> +                             cfg->dbusStateDir);

Minor notes on the message:
- spell "D-Bus" correctly
- no need to abbreviate "directory"
- quote the path placeholder
so I suggest something like:
  "Failed to create the D-Bus state directory '%s'"

(Can't comment on the rest of the changes, sorry.)

Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200722/2446e33c/attachment-0001.sig>

More information about the libvir-list mailing list