[libvirt PATCH 3/4] tests: don't mock the time() function on mingw

Laine Stump laine at redhat.com
Wed Jul 22 20:03:44 UTC 2020


On 7/22/20 1:21 PM, Daniel P. Berrangé wrote:
> The mingw header define time() as a static inline function and this
> causes a duplicate definition build failure. Since we're not using the
> LD_PRELOAD at all on Mingw, we ideally wouldn't compile any of the
> mock libraries. Rather than change the build system now though, this
> just stubs out the offending function.
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>


Reviewed-by: Laine Stump <laine at redhat.com>


> ---
>   tests/virnetdaemonmock.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/virnetdaemonmock.c b/tests/virnetdaemonmock.c
> index 3b92fff8c9..c523da0791 100644
> --- a/tests/virnetdaemonmock.c
> +++ b/tests/virnetdaemonmock.c
> @@ -23,6 +23,7 @@
>   
>   #define VIR_FROM_THIS VIR_FROM_NONE
>   
> +#ifndef WIN32
>   time_t time(time_t *t)
>   {
>       const time_t ret = 1234567890;
> @@ -30,3 +31,4 @@ time_t time(time_t *t)
>           *t = ret;
>       return ret;
>   }
> +#endif





More information about the libvir-list mailing list