[libvirt PATCH 000/351] port libvirt to Meson build system
pkrempa at redhat.com
Tue Jul 28 10:19:41 UTC 2020
On Tue, Jul 28, 2020 at 12:08:17 +0200, Pavel Hrdina wrote:
> On Tue, Jul 28, 2020 at 10:58:03AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
> > - Meson build is forced to fail out of the box
> > - An option "force_incomplete_build" to turn off the fail
> > - When failing prints an error message
> > "This commit is part of the meson conversion and does not
> > build a complete libvirt. If bisecting, use "git bisect skip"
> > to continue, or "-Dforce_incomplete_build=true" to perform a
> > partial build"
> > So with that we would have full history, and git bisect would be able
> > to identify problems in ANY commit that is NOT part of the meson
> > series, except the single commit that is immediately either side of
> > the meson series. That should be viable I think.
> I like the extra option which would be removed once we remove the error
> message as well. It makes nice compromise between options 2) and 3).
> Peter suggested using the error message in a private conversation that
> we had and this improves it a bit more so if we can agree on this
> I'll go with it.
I reckon that doing a build at any point partway in the series is
generally not useful, but sure option 3 is my minimum requirement, so if
that is what happens by default I don't mind if you add the extra
More information about the libvir-list