[libvirt PATCH 000/351] port libvirt to Meson build system
jtomko at redhat.com
Tue Jul 28 10:24:56 UTC 2020
On a Tuesday in 2020, Daniel P. Berrangé wrote:
>On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
>> 3) Keep the patches as they are but error out in meson until the
>> conversion is complete. The error can be used to detect if git
>> bisect is withing the meson rewrite.
>> Pros: - full history of changes where each commit removes the
>> relevant bits from autotools
>> - git bisect is not broken if failed compilation is not an
>> issue and marked as git bisect skip
>> Cons: - meson build will fail and there is no autogen.sh so no
>> way how to compile libvirt even partially
>> - script used for git bisect will have to skip failed
>> compilation with an option to check for specific error
>..So explicitly failing the meson build is a significant improvement.
>We could have
> - Meson build is forced to fail out of the box
> - An option "force_incomplete_build" to turn off the fail
> - When failing prints an error message
> "This commit is part of the meson conversion and does not
> build a complete libvirt. If bisecting, use "git bisect skip"
> to continue, or "-Dforce_incomplete_build=true" to perform a
> partial build"
For unattended bisects, it would be nice to return 125 which is the
magic value meaning 'skip' to 'git bisect run'.
>So with that we would have full history, and git bisect would be able
>to identify problems in ANY commit that is NOT part of the meson
>series, except the single commit that is immediately either side of
>the meson series. That should be viable I think.
>> 4) Rework the series to have patches adding meson bits without
>> removing anything from autotools and drop the autotools files in
>> a single commit once the meson rewrite is complete
>> Pros: - full history of changes
>> - git bisect not broken because autogen.sh && make will
>> work the whole time until meson build && ninja is ready
>> Cons: - no reference of the meson changes to autotools code
>> - additional work for me to redo the patches
>|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org -o- https://fstop138.berrange.com :|
>|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 488 bytes
Desc: not available
More information about the libvir-list