[libvirt PATCH 4/4] ci: use 'needs' more often
abologna at redhat.com
Wed Jul 29 08:46:13 UTC 2020
On Wed, 2020-07-29 at 01:36 +0200, Ján Tomko wrote:
> Make the pipeline chart more interesting.
Maybe include a short summary of the actual motivation here :)
> +++ b/.gitlab-ci.yml
> @@ -268,41 +268,49 @@ mingw64-fedora-rawhide-container:
> <<: *native_build_job_definition
> + needs: ["x64-debian-10-container"]
> NAME: debian-10
Why are you limiting this change to a subset of the build jobs? It
seems to me that this approach can be used for all of them, both
native and cross.
And please use the
syntax, since that's what we use for lists everywhere else.
I also thought we could make this much nicer by using something
but it turns out that GitLab doesn't support variable expansion
inside of 'needs', so that's unfortunately not viable :(
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list